Updates read_many_structs benchmark
#837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
force-pushed
the
fix-read-bench
branch
from
4f1f8ec
to
e2cbf1f
Compare
zslayton
force-pushed
the
fix-read-bench
branch
from
e2cbf1f
to
ef79453
Compare
popematt
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #836.
There are more system macros than there were when
read_many_structswas first written. I've updated the macro ID used in the encoding to reflect that. I've also corrected a mismatch in the 1.0 and 1.1 encoding samples; one usedabc-123as the hostname while the other usedabc123. They now both useabc123.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.